Insert headers to &mut OwnedHeaders inplace#816
Open
SickMcNugget wants to merge 1 commit intofede1024:masterfrom
Open
Insert headers to &mut OwnedHeaders inplace#816SickMcNugget wants to merge 1 commit intofede1024:masterfrom
SickMcNugget wants to merge 1 commit intofede1024:masterfrom
Conversation
This commit adds a new function insert_inplace(), that takes a mutable reference to an OwnedHeaders, and can insert headers to that reference. The body of insert() has been deduplicated into insert_internal(), and the new functionality is also tested inside of test_headers().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #815.
This commit adds a new function:
insert_inplace(), that takes in an&mut OwnedHeaders, and can insert headers into that reference without requiring reassignment.The body of
insert()has been deduplicated intoinsert_internal(), and the new functionality is also tested inside oftest_headers().