Feat Enhance playlist UI with tooltips and inline editing features#631
Open
saulob wants to merge 11 commits intofatihak:mainfrom
Open
Feat Enhance playlist UI with tooltips and inline editing features#631saulob wants to merge 11 commits intofatihak:mainfrom
saulob wants to merge 11 commits intofatihak:mainfrom
Conversation
added 5 commits
March 20, 2026 22:17
Add title="Edit instance settings" to the playlist settings button and the plugin edit link in the playlist view to improve accessibility and UX.
- Add title="Edit Playlist" to playlist settings button. - Add title="Edit Instance Settings" to plugin edit button. - Remove redundant title attributes from <img> elements (keep titles on buttons only).
- Feature: Add inline editing for plugin instance names click to edit, blur or Enter to save, Esc to cancel - Backend: Add rename_plugin_instance endpoint to persist renames and rename associated images - Unicode: Normalize names using NFC and add a diacritics-insensitive fallback for accented characters - UX: Standardize control tooltips and remove redundant image titles - Stability: Prevent duplicate submissions caused by Enter and blur firing together
There was a problem hiding this comment.
Pull request overview
Adds inline renaming of playlist plugin instances, backed by a new API endpoint, plus small UI affordances (hover styles, tooltips, edit pencil icon).
Changes:
- Added
PUT /rename_plugin_instanceendpoint to rename a plugin instance (with Unicode normalization / diacritics-insensitive matching) and attempt image-file renaming. - Implemented inline editing UI in
playlist.html(input-on-click, blur/Enter submit, Escape cancel) and updates some in-row attributes/links after rename. - Added a pencil icon asset and minor tooltip/hover styling improvements.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/templates/playlist.html | Adds inline rename UI/JS, hover styling, and tooltips for playlist/plugin controls. |
| src/blueprints/playlist.py | Introduces backend rename endpoint and attempts to rename associated generated image file. |
| src/static/icons/edit_pencil.png | New UI icon for the inline rename affordance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 6 commits
March 22, 2026 16:58
…ing with proper ambiguity handling
…nd only persist the new instance name after a successful image update
… of replacing element content, preserving child elements such as the edit icon
…gin instance names
…enaming to ensure UI consistency
…oss all playlists
saulob
changed the title
Author
|
All Copilot review comments addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for inline renaming of plugin instances within a playlist, both in the backend API and the frontend user interface. The changes include a new API endpoint to handle renaming with Unicode and diacritics-aware matching, updates to the HTML and JavaScript to enable inline editing, and improved UI feedback and accessibility for these actions.
Backend: Playlist plugin instance renaming
rename_plugin_instanceAPI endpoint inplaylist.pyto allow renaming a plugin instance within a playlist, including Unicode normalization and diacritics-insensitive matching for robust name handling. The endpoint also handles renaming associated image files and provides detailed error feedback.Frontend: Inline editing and UI enhancements
playlist.htmlusing JavaScript, enabling users to rename instances directly in the UI with real-time validation and feedback. This includes updating all relevant data attributes and links after a rename. [1] [2]Summary
Improve playlist UX by adding inline rename for plugin instances with a subtle pencil indicator, hover feedback and better interaction handling
Changes
Files
Impact