Remove obsolete TODO comments in test files #1891
Open
adityamoolya wants to merge 2 commits intofastapi:mainfrom
Open
Remove obsolete TODO comments in test files #1891adityamoolya wants to merge 2 commits intofastapi:mainfrom
adityamoolya wants to merge 2 commits intofastapi:mainfrom
Conversation
Author
|
This PR appears to be failing the required label check. I believe "docs" would be the appropriate label for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Removed two TODO comments from tests/test_tutorial/test_one/test_tutorial004.py and tests/test_tutorial/test_one/test_tutorial005.py
Why:
The TODOs asked for a delete() function and exec() overloads for delete objects ,both were already resolved in #1342 (which added UpdateBase overloads to Session.exec())
Scope:
Comment removal only, no logic changes, tests pass