perf: cache key building and handler hex processing#646
Open
Sahil-4555 wants to merge 1 commit intoethpandaops:masterfrom
Open
perf: cache key building and handler hex processing#646Sahil-4555 wants to merge 1 commit intoethpandaops:masterfrom
Sahil-4555 wants to merge 1 commit intoethpandaops:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up internal string handling in the
cacheandhandlerspackages.Used plain string concatenation instead of
fmt.Sprintffor redis key building, andstrconv.FormatUint/strconv.FormatBoolfor value serialization. Fixed a bug whereGetBoolwas missing the key prefix so lookups never matched. Extracted apageKeyPrefixhelper usingstrings.Cutinstead ofstrings.Splitfor cache key parsing. Fixed a race in the SSZ compatibility check by re-checking the map after acquiring the write lock. In the handlers, replacedstrings.Replace(s, "0x", "", -1)withstrings.TrimPrefixsince we only strip the leading prefix. Switchedfmt.Sprintf("%x", hash)tohex.EncodeToStringfor map key encoding to match the DB layer. Replacedfmt.Sprintfbyte-slice comparison withbytes.Equal. Returned a string literal for constant client type name instead of formatting it at runtime.prefix + keyinstead offmt.Sprintffor cache keysstrings.Cutinstead ofstrings.Splitfor key prefixstrings.TrimPrefixinstead ofstrings.Replacefor 0xhex.EncodeToStringinstead offmt.Sprintf("%x")for map keysbytes.Equalinstead offmt.Sprintfcompare for block hashesfmt.Sprintffor client type