perf(blockdb): simplify storage helpers and reduce lookup overhead#643
Merged
pk910 merged 6 commits intoethpandaops:masterfrom Apr 17, 2026
Merged
Conversation
pk910
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances blockdb by removing redundant storage operations and simplifying common logic amongst storage engines. The primary enhancement is in local component lookup, which now use a single bounded scan rather than numerous independent lookups, decreasing benchmark time by about 50% and reducing resources. It also batches local component writes, centralizes shared component-flag detection, and simplifies S3 key handling and exec-data slot parsing, with the slot parsing helper outperforming benchmark results by around 95%.