agent: expose DISABLE_IDLE_TASKS and DISABLE_FAILING_TASKS separately#2802
Merged
agent: expose DISABLE_IDLE_TASKS and DISABLE_FAILING_TASKS separately#2802
DISABLE_IDLE_TASKS and DISABLE_FAILING_TASKS separately#2802Conversation
jshearer
force-pushed
the
agent/independently_control_disablement
branch
from
b3bcf33 to
107bf68
Compare
jshearer
force-pushed
the
agent/independently_control_disablement
branch
from
107bf68 to
1cabb8d
Compare
The single `DISABLE_ABANDONED_TASKS` env var prevented turning on auto-disable for idle tasks without also enabling it for chronically failing tasks. Replaces it with `DISABLE_IDLE_TASKS` and `DISABLE_FAILING_TASKS` so each can be enabled independently.
jshearer
force-pushed
the
agent/independently_control_disablement
branch
from
1cabb8d to
1d51882
Compare
GregorShear
reviewed
Mar 31, 2026
Contributor
There was a problem hiding this comment.
the concept of "abandoned tasks" isn't going away, right? DISABLE_ABANDONED_TASKS is splitting into two more specific flags, but we'll still use the term "abandoned" generally? (mostly just trying to get up to speed here...)
Contributor
Author
There was a problem hiding this comment.
yeah that's right. I tried to think of naming for these env vars that contained the word ABANDONED but the ones I came up with were too wordy imo so I went with what I have here
GregorShear
approved these changes
Mar 31, 2026
Contributor
GregorShear
left a comment
GregorShear
left a comment
There was a problem hiding this comment.
Consider testing isolation between the two flags, i.e. a chronically failing task is not disabled when the idle flag is on. Not a blocker...
…NG_TASKS` * A chronically failing task with an expired grace period remains enabled when only `disable_idle_tasks` is set * An idle task with an expired grace period remains enabled when only `disable_failing_tasks` is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DISABLE_ABANDONED_TASKSwith two independent env vars:DISABLE_IDLE_TASKSandDISABLE_FAILING_TASKS, both defaulting tofalseContext
Discussion about abandoned task tracking surfaced that many chronically failing tasks are still actively moving data, and the upshot is that we should be able to enable idle-task disablement independently while we work on improving shard failure alerting before acting on chronically failing tasks.