InputHud: Allow custom built player

[manuq]

Consider that a player is no more than a CharacterBody2D, that is the first node in group "player". An thus may or may not have features like PlayerInteraction, PlayerRepel, or PlayerHook.

This fixes the gym_area_test scene, which has a custom built player.

[manuq]

The (fantastic) recent changes in input hints broke the res://scenes/game_elements/characters/components/gym_area_test.tscn scene, which has a custom built player using the InputWalkBehavior in a CharacterBody2D.

[github-actions]

Play this branch at https://play.threadbare.game/branches/endlessm/fix-gym-scene/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

[wjt]

Makes sense, I think you could tweak the dynamic lookup though.

I wonder if scenes/quests/story_quests/champ/3_stealth/champ_stealth.tscn still works - it uses a custom character.

[wjt]

This (untested) is a little more concise and perhaps a bit clearer:

Suggested change

	if "player_interaction" in player:
	player_interaction = player.player_interaction as PlayerInteraction
	if player_interaction:
	player_interaction.can_interact_changed.connect(_update_player_state)
	player_interaction = player.get("player_interaction") as PlayerInteraction
	if player_interaction:
	player_interaction.can_interact_changed.connect(_update_player_state)

[manuq]

Much better, and even works!

[manuq]

I was about to slip #2099 in here but better not!

[manuq]

Makes sense, I think you could tweak the dynamic lookup though.

I wonder if scenes/quests/story_quests/champ/3_stealth/champ_stealth.tscn still works - it uses a custom character.

Oh, let me check before merging.

[manuq]

Makes sense, I think you could tweak the dynamic lookup though.
I wonder if scenes/quests/story_quests/champ/3_stealth/champ_stealth.tscn still works - it uses a custom character.

Oh, let me check before merging.

The level scene works. The hints don't appear but only because the CharacterBody2D is not in group "player". I wonder if that is left to the learners. The level scene also has its custom input hints:

So adding player to group "player" shows both overlapped:

I'm going to merge as-is for now.

[wjt]

An open question is how we would adjust the global HUD labels for quests where the character has different abilities.

[manuq]

An open question is how we would adjust the global HUD labels for quests where the character has different abilities.

I was thinking the same thing! Maybe the quest.tres can have a mapping of ability to its name and input action. Or just name and by convention ABILITY_A is always the repel input action, ABILITY_B is always the throw input action... But then what to do with aim which is 4 input actions? Tricky.