Fix: Do not destroy the MainWindow on close when the indicator is enabled#530
Merged
Fix: Do not destroy the MainWindow on close when the indicator is enabled#530
Conversation
stsdc
force-pushed
the
stsdc/fix-window-close
branch
from
b80cb17 to
4638a85
Compare
stsdc
changed the title
vjr
approved these changes
Mar 20, 2026
Member
vjr
left a comment
vjr
left a comment
There was a problem hiding this comment.
LGTM except some comments/suggestions but not to block merging this PR.
| construct { | ||
| title = _("Monitor"); | ||
|
|
||
| close_request.connect (() => { |
Member
There was a problem hiding this comment.
Other than the couple of comments I could think about, this PR seems good to merge to me.
It at least fixes for me the need to twice click "show monitor" in panel indicator, now it works everytime first click.
I could not repro perf issue but it could be because I am on a fast desktop PC - I didn't see any issue with window updates (CPU graphs always being smooth) etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents creating new Timeouts every time a new window is constructed, which results in multiple resources updates per second