fix(search): improve project root path detection logic#1178
Open
beyondkmp wants to merge 2 commits intoelectron:mainfrom
Open
fix(search): improve project root path detection logic#1178beyondkmp wants to merge 2 commits intoelectron:mainfrom
beyondkmp wants to merge 2 commits intoelectron:mainfrom
Conversation
erickzhao
reviewed
Apr 7, 2025
Member
erickzhao
left a comment
erickzhao
left a comment
There was a problem hiding this comment.
Can you address the lint failures?
erickzhao
reviewed
Apr 7, 2025
Member
erickzhao
left a comment
erickzhao
left a comment
There was a problem hiding this comment.
Can we also add additional test coverage for this use case?
Author
|
Yes. UT is added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My project structure is as follows:
There is a
yarn.lockfile under/User/test, and apnpm-lock.yamlfile underproject. The project root directory I want to obtain is/User/test/Project, but what is returned is/User/test.We need to search for all three, and then return the longest one.