Closed
Conversation
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
asset |
1976.28 | 1449.28 | -527 (-26.67%) | 💔 |
audit |
3144.65 | 2645.5 | -499.15 (-15.87%) | 💔 |
source |
66666.67 | 35714.29 | -30952.38 (-46.43%) | 💔 |
To see the full report comment with /test benchmark fullreport
Contributor
Author
|
CI error (failing system tests inside |
|
Pinging @elastic/ecosystem (Team:Ecosystem) |
Contributor
Author
|
/test |
|
💚 Build Succeeded
History
cc @kcreddy |
Contributor
Author
|
@elastic/ecosystem PTAL. This PR prevents skewing of SonarQube coverage quality due to unchecked files by adding exclusions on them. Example: #14809 (comment). |
Member
|
I would prefer to update coverage reports in elastic-package, at least for the files covered by some test. Doing this in elastic/elastic-package#2831. |
Contributor
Author
|
Closing in favour of adding coverage: elastic/elastic-package#2831 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Proposed commit message
Currently almost all PRs that has changes to transform fail
SonarQube checks because transform code is not covered
by any of the tests. Example: #14629 (comment)
Until elastic/elastic-package#2704 is implemented, this
temporary fix ensures SonarQube skips following files where
the coverage is not yet offered by
elastic-packagetests,thus avoiding false positives:
Related issues