Skip to content

Add auto generation support for content package readme generation#3479

Merged
ishleenk17 merged 2 commits intoelastic:mainfrom
ishleenk17:readme_cpntentpackage_ep
Apr 21, 2026
Merged

Add auto generation support for content package readme generation#3479
ishleenk17 merged 2 commits intoelastic:mainfrom
ishleenk17:readme_cpntentpackage_ep

Conversation

@ishleenk17
Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 requested a review from jsoriano April 20, 2026 06:23
Copy link
Copy Markdown
Contributor

@teresaromero teresaromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think the ci failure is related to this change. perhaps the base branch is outdated? we fixed recently the zipkin errors... could you update the branch and check tests pass?

other than that i dont see any blocker for this, unless the fact that we need 3.6.1 package-spec bumped into elastic-package for this change? WDYT cc @mrodm

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Apr 20, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

History

@mrodm
Copy link
Copy Markdown
Contributor

mrodm commented Apr 20, 2026

other than that i dont see any blocker for this, unless the fact that we need 3.6.1 package-spec bumped into elastic-package for this change? WDYT cc @mrodm

LGTM. As you mentioned, a new package-spec release should be updated in elastic-package (containing elastic/package-spec#1144) in order to be able to use the folder _dev/build/docs. Until that happens, any content package adding _dev/build/docs folder will fail when running elastic-package check command.

@ishleenk17
Copy link
Copy Markdown
Member Author

other than that i dont see any blocker for this, unless the fact that we need 3.6.1 package-spec bumped into elastic-package for this change? WDYT cc @mrodm

LGTM. As you mentioned, a new package-spec release should be updated in elastic-package (containing elastic/package-spec#1144) in order to be able to use the folder _dev/build/docs. Until that happens, any content package adding _dev/build/docs folder will fail when running elastic-package check command.

@mrodm
For now we don't have any package using autogeneration yet. So , IMO we should be good to merge this.
Once the new version of elastic-package is released I will update my team to use it.

@ishleenk17 ishleenk17 merged commit 479553b into elastic:main Apr 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants