lb: fix http client leak

lb/backend.go

@@ -60,52 +60,54 @@ func NewBackend(backendConfig BackendConfig) *Backend {
 func (b *Backend) HeartCheck() {
 	go func() {
 		for {
-			var request *http.Request
-			var err error
-
-			client := &http.Client{}
-			request, err = http.NewRequest(b.HBMethod, b.Heartbeat, nil)
-			request.Header.Set("User-Agent", "SSLB-Heartbeat")
-
-			resp, err := client.Do(request)
-			if err != nil || resp.StatusCode >= 400 {
-				b.RWMutex.Lock()
-				// Max tries before consider inactive
-				if b.InactiveTries >= b.InactiveAfter {
-					log.Printf("Backend inactive [%s]", b.Name)
-					b.Active = false
-					b.ActiveTries = 0
+			func() {
+				var request *http.Request
+				var err error
+
+				client := &http.Client{}
+				request, err = http.NewRequest(b.HBMethod, b.Heartbeat, nil)
+				request.Header.Set("User-Agent", "SSLB-Heartbeat")
+
+				resp, err := client.Do(request)
+				if err != nil || resp.StatusCode >= 400 {
+					b.RWMutex.Lock()
+					// Max tries before consider inactive
+					if b.InactiveTries >= b.InactiveAfter {
+						log.Printf("Backend inactive [%s]", b.Name)
+						b.Active = false
+						b.ActiveTries = 0
+					} else {
+						// Ok that guy it's out of the game
+						b.Failed = true
+						b.InactiveTries++
+						log.Printf("Error to check address [%s] name [%s] tries [%d]", b.Heartbeat, b.Name, b.InactiveTries)
+					}
+					b.RWMutex.Unlock()
 				} else {
-					// Ok that guy it's out of the game
-					b.Failed = true
-					b.InactiveTries++
-					log.Printf("Error to check address [%s] name [%s] tries [%d]", b.Heartbeat, b.Name, b.InactiveTries)
-				}
-				b.RWMutex.Unlock()
-			} else {
-				defer resp.Body.Close()
-
-				// Ok, let's keep working boys
-				b.RWMutex.Lock()
-				if b.ActiveTries >= b.ActiveAfter {
-					if b.Failed {
-						log.Printf("Backend active [%s]", b.Name)
+					defer resp.Body.Close()
+
+					// Ok, let's keep working boys
+					b.RWMutex.Lock()
+					if b.ActiveTries >= b.ActiveAfter {
+						if b.Failed {
+							log.Printf("Backend active [%s]", b.Name)
+						}
+
+						b.Failed = false
+						b.Active = true
+						b.InactiveTries = 0
+					} else {
+						b.ActiveTries++
 					}
+					b.RWMutex.Unlock()
+				}
 
-					b.Failed = false
-					b.Active = true
-					b.InactiveTries = 0
+				if b.Failed {
+					time.Sleep(b.RetryTime)
 				} else {
-					b.ActiveTries++
+					time.Sleep(b.HeartbeatTime)
 				}
-				b.RWMutex.Unlock()
-			}
-
-			if b.Failed {
-				time.Sleep(b.RetryTime)
-			} else {
-				time.Sleep(b.HeartbeatTime)
-			}
+			}()
 		}
 	}()
 }