Skip to content

add analytics#44

Open
edge-marge wants to merge 5 commits intomainfrom
feature/analytics
Open

add analytics#44
edge-marge wants to merge 5 commits intomainfrom
feature/analytics

Conversation

@edge-marge
Copy link
Copy Markdown
Contributor

do not merge - missing distinct_id

@orcist
Copy link
Copy Markdown
Collaborator

orcist commented Mar 23, 2026

@edge-marge wouldn't this implementation create a new instance of AnalyticsApi every time you access the property? Maybe it would be better to declare it once as a property and reuse it after?

private AnalyticsApi Analytics = new AnalyticsApi(getDistinctId());

also, it seems this implementation has hardcoded the UTM source, could you instead get the value dynamically from EdgegapWindowMetadata.DEFAULT_UTM_SOURCE_TAG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants