Align Kafka loader with project conventions and improve robustness#46
Open
fordN wants to merge 1 commit intokrishna/kafkafrom
Open
Align Kafka loader with project conventions and improve robustness#46fordN wants to merge 1 commit intokrishna/kafkafrom
fordN wants to merge 1 commit intokrishna/kafkafrom
Conversation
- Fix SUPPORTS_TRANSACTIONS flag (False, since base class routes via hasattr) - Add health_check() method using sender thread liveness - Move test file to canonical location (backends/test_kafka.py) - Add health check integration test - Add make test-kafka target - Improve crash recovery to skip reorg when no uncommitted batches - Flush producer before committing transactions - Reduce container startup wait (already waits for KafkaServer log)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few suggestions for the Kafka loader @incrypto32! Let me know what you think
Changes