Skip to content

Add default value protection for line coding parameters in serial Host classes #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayedm1 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add default value protection for line coding parameters in serial Host classes #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/usbx_host_classes/inc/ux_host_class_cdc_acm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,21 @@ extern "C" {

/* Define CDC ACM default values. */

#ifndef UX_HOST_CLASS_CDC_ACM_LINE_CODING_DEFAULT_RATE
#define UX_HOST_CLASS_CDC_ACM_LINE_CODING_DEFAULT_RATE 9600
#endif

#ifndef UX_HOST_CLASS_CDC_ACM_LINE_CODING_DEFAULT_STOP_BIT
#define UX_HOST_CLASS_CDC_ACM_LINE_CODING_DEFAULT_STOP_BIT 0
#endif

#ifndef UX_HOST_CLASS_CDC_ACM_LINE_CODING_DEFAULT_PARITY
#define UX_HOST_CLASS_CDC_ACM_LINE_CODING_DEFAULT_PARITY 0
#endif

#ifndef UX_HOST_CLASS_CDC_ACM_LINE_CODING_DEFAULT_DATA_BIT
#define UX_HOST_CLASS_CDC_ACM_LINE_CODING_DEFAULT_DATA_BIT 8
#endif

/* Define CDC ACM line coding definitions. */

Expand Down
13 changes: 13 additions & 0 deletions common/usbx_host_classes/inc/ux_host_class_gser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,21 @@ extern "C" {

/* Define CDC ACM default values. */

#ifndef UX_HOST_CLASS_GSER_LINE_CODING_DEFAULT_RATE
#define UX_HOST_CLASS_GSER_LINE_CODING_DEFAULT_RATE 9600
#endif

#ifndef UX_HOST_CLASS_GSER_LINE_CODING_DEFAULT_STOP_BIT
#define UX_HOST_CLASS_GSER_LINE_CODING_DEFAULT_STOP_BIT 0
#endif

#ifndef UX_HOST_CLASS_GSER_LINE_CODING_DEFAULT_PARITY
#define UX_HOST_CLASS_GSER_LINE_CODING_DEFAULT_PARITY 0
#endif

#ifndef UX_HOST_CLASS_GSER_LINE_CODING_DEFAULT_DATA_BIT
#define UX_HOST_CLASS_GSER_LINE_CODING_DEFAULT_DATA_BIT 8
#endif

/* Define CDC ACM line coding definitions. */

Expand Down
13 changes: 13 additions & 0 deletions common/usbx_host_classes/inc/ux_host_class_prolific.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,21 @@ extern "C" {

/* Define PROLIFIC default values. */

#ifndef UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_RATE
#define UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_RATE 19200
#endif

#ifndef UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_STOP_BIT
#define UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_STOP_BIT 0
#endif

#ifndef UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_PARITY
#define UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_PARITY 0
#endif

#ifndef UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_DATA_BIT
#define UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_DATA_BIT 8
#endif

/* Define PROLIFIC line coding definitions. */

Expand Down
4 changes: 2 additions & 2 deletions common/usbx_host_classes/src/ux_host_class_prolific_activate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ UINT status;
if (status == UX_SUCCESS)
{
line_coding.ux_host_class_prolific_line_coding_dter = UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_RATE;
line_coding.ux_host_class_prolific_line_coding_stop_bit = UX_HOST_CLASS_PROLIFIC_LINE_CODING_STOP_BIT_0;
line_coding.ux_host_class_prolific_line_coding_parity = UX_HOST_CLASS_PROLIFIC_LINE_CODING_PARITY_NONE;
line_coding.ux_host_class_prolific_line_coding_stop_bit = UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_STOP_BIT;
line_coding.ux_host_class_prolific_line_coding_parity = UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_PARITY;
line_coding.ux_host_class_prolific_line_coding_data_bits = UX_HOST_CLASS_PROLIFIC_LINE_CODING_DEFAULT_DATA_BIT;
status = _ux_host_class_prolific_ioctl(prolific, UX_HOST_CLASS_PROLIFIC_IOCTL_SET_LINE_CODING, (VOID *) &line_coding);
}
Expand Down
Loading