fix(calendar-dropdown): exponer onClick en EventsList y soportar clic…#764
Merged
Jonathangarrido merged 2 commits intomainfrom Mar 26, 2026
Merged
fix(calendar-dropdown): exponer onClick en EventsList y soportar clic…#764Jonathangarrido merged 2 commits intomainfrom
Jonathangarrido merged 2 commits intomainfrom
Conversation
Deploying ui-kit with
|
| Latest commit: |
85da459
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf6f8413.ui-kit-316.pages.dev |
| Branch Preview URL: | https://fix-calendar-onclick.ui-kit-316.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Se actualiza
EventsListen@eclass/ui-kitpara soportaronClickde forma nativa en su API pública y evitar wrappers externos solo para capturar el click.Además, se deja cobertura de prueba para el comportamiento clickeable y se alinea la documentación del componente con la nueva prop.
Motivación y contexto
En consumidores del repo v8,
EventsListse usa como item navegable dentro de calendarios y modales, pero su tipado no exponíaonClick, lo que generaba errores de TypeScript como:Property 'onClick' does not exist on type 'IntrinsicAttributes & IEventList'Con este cambio, el componente acepta
onClickdirectamente y mantiene el comportamiento esperado para ese caso de uso.Tipos de cambios