Skip to content

Create base class#144

Open
henrikjacobsenfys wants to merge 4 commits intodevelopfrom
create-base-class
Open

Create base class#144
henrikjacobsenfys wants to merge 4 commits intodevelopfrom
create-base-class

Conversation

@henrikjacobsenfys
Copy link
Copy Markdown
Member

@henrikjacobsenfys henrikjacobsenfys commented Mar 30, 2026

Moves unit to a base class to centralize checks.

Also (re)introduces a name property that will replace unique_name for the users and make it easier to work with components by inheriting from EasyList. (see #117 and #70 )

Closes #92
Closes #73 as redundant

@henrikjacobsenfys henrikjacobsenfys added [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] medium Normal/default priority labels Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 97.53086% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.82%. Comparing base (95c2018) to head (46a6823).

Files with missing lines Patch % Lines
src/easydynamics/sample_model/model_base.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #144      +/-   ##
===========================================
- Coverage    97.84%   97.82%   -0.03%     
===========================================
  Files           38       41       +3     
  Lines         2595     2616      +21     
  Branches       452      454       +2     
===========================================
+ Hits          2539     2559      +20     
- Misses          32       34       +2     
+ Partials        24       23       -1     
Flag Coverage Δ
integration 48.73% <56.79%> (+0.18%) ⬆️
unittests 97.82% <97.53%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] medium Normal/default priority [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make a base class for some common attributes Consider moving unit checks to utils

1 participant