Skip to content

Add Gauss/Lorentz model switch to Becker-Coppens extinction#149

Merged
AndrewSazonov merged 2 commits intodevelopfrom
extinction
Apr 9, 2026
Merged

Add Gauss/Lorentz model switch to Becker-Coppens extinction#149
AndrewSazonov merged 2 commits intodevelopfrom
extinction

Conversation

@AndrewSazonov
Copy link
Copy Markdown
Member

The extinction correction was incorrectly labelled as Shelx-style. CrysPy implements analytical Becker-Coppens spherical extinction (primary x secondary), not the empirical Shelx model.

  • Rename ShelxExtinction -> BeckerCoppensExtinction (tag becker-coppens)
  • Add model StringDescriptor to switch between 'gauss' and 'lorentz' mosaicity distributions

@AndrewSazonov AndrewSazonov added the [scope] enhancement Adds/improves features (major.MINOR.patch) label Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.17%. Comparing base (58b4b29) to head (071894f).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...asydiffraction/datablocks/experiment/item/enums.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #149      +/-   ##
===========================================
- Coverage    89.21%   89.17%   -0.04%     
===========================================
  Files          134      134              
  Lines         7694     7716      +22     
  Branches       723      725       +2     
===========================================
+ Hits          6864     6881      +17     
- Misses         600      605       +5     
  Partials       230      230              
Flag Coverage Δ
integration 74.96% <76.00%> (-0.01%) ⬇️
unittests 79.89% <76.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndrewSazonov AndrewSazonov merged commit 007004a into develop Apr 9, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant