Fixed minimizer behaviour on exceeded iterations#231
Open
Fixed minimizer behaviour on exceeded iterations#231
Conversation
rozyczko
added
[scope] enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
henrikjacobsenfys
approved these changes
Apr 10, 2026
Member
henrikjacobsenfys
left a comment
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
Looks good to me apart from a tiny nitpick.
This may also be a good opportunity to make a __repr__ method for the FitResults class?
|
|
||
| assert result.success is False | ||
| assert result.n_evaluations is not None | ||
| assert result.n_evaluations > 0 |
Member
There was a problem hiding this comment.
Would it make sense to check that n_evaluations matches the budget?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds improvements to the fitting result reporting and evaluation tracking across all minimizer engines, ensuring that the number of function evaluations and relevant messages are consistently captured and propagated.
All minimizer engines (
Bumps,DFO,LMFit) now populaten_evaluations(number of function evaluations) andmessage(status or error message) fields inFitResults, and these fields are propagated in multi-dataset fitting.The
Bumpsminimizer uses a new_EvalCounterwrapper to count function evaluations and detect when the maximum evaluation budget is reached, updating thesuccessflag and message accordingly.The
DFOminimizer now raisesFitErroronly for real failures, and considers both success and max function evaluation warnings as successful fits, improving error reporting and testability.