Add QtGraphs-based analysis page to AdvancedPy example#39
Add QtGraphs-based analysis page to AdvancedPy example#39AndrewSazonov wants to merge 11 commits intodevelopfrom
Conversation
AndrewSazonov
added
[scope] enhancement
rozyczko
left a comment
rozyczko
left a comment
There was a problem hiding this comment.
A few minor issues found. Please consider before merging.
|
|
||
| QtObject { | ||
|
|
||
| property int dataSize: 50 |
There was a problem hiding this comment.
the default dataSize in corresponding analysis.py is set to 10000. Why the difference?
There was a problem hiding this comment.
This mismatch is intentional. In the mock backend I only generate random noise, so I kept the dataset small to keep the chart responsive during QML-side development. In the Python backend the generated data is closer to a real peak pattern, and I chose 10000 to demonstrate that chart updates are still smooth at that size.
| //visible: true | ||
| //gridVisible: false | ||
| //subGridVisible: true | ||
| //labelsVisible: true | ||
| //subTickCount: 1 |
There was a problem hiding this comment.
Lots of commented-out code in this file. Please either comment on why it needs to stay or remove.
There was a problem hiding this comment.
Right. I left those comments there mainly as a reminder of the chart styling properties supported by QtGraphs. My plan is to use this example as a basis for a reusable chart template in EasyApp/Gui/Charts, so we do not have to repeat a large block of theme configuration in each chart. I will remove it once this reusable chart template is implemented.
| labelDelegate: TextEdit { | ||
| horizontalAlignment: TextInput.AlignHCenter |
There was a problem hiding this comment.
Is this supposed to be TextEdit? Are you expected to be able to edit axis labels?
I think you meant labelDelegate: Text
There was a problem hiding this comment.
Yes, it is supposed to be non-editable text. Thanks for catching that.
| mvx = memoryview(x) | ||
| mvy = memoryview(y) | ||
| return [QPointF(xi, yi) for xi, yi in zip(mvx, mvy)] |
There was a problem hiding this comment.
memoryview avoids copying indeed, but when you later iterate over it with zip, each element is still converted from the memoryview into a Python float object before being passed to QPointF.
You're still doing float conversion...
>>> a = np.array([1.0, 2.0])
>>> for x in memoryview(a):
... print(type(x))
<class 'float'>
<class 'float'>There was a problem hiding this comment.
Right, memoryview does not help here. I removed it and simplified the helper.
| x, y = self._generate_data(n_points=self.dataSize) | ||
| console.debug(" Data generation completed.") |
There was a problem hiding this comment.
No exception handling on results from _generate_data, which might throw.
There was a problem hiding this comment.
I added exception handling in generateData() so failures are logged instead of propagating into the UI.
2 participants
This PR adds a new Analysis page to the AdvancedPy example and connects it to both mock QML and real Python backends.
Analysis page includes: