Skip to content

Changed the behaviour of TableViewTextInput to loose focus on enter/return #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seventil wants to merge 4 commits into
base: develop
Choose a base branch
from
+32 −2
Open

Changed the behaviour of TableViewTextInput to loose focus on enter/return #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
270bd5e
Changed the behviour of TableViewTextInput to loose focus on enter/re…
seventil Mar 16, 2026
0b5fec2
Moved the logic of toggling focus to TextField and TextInput
seventil Mar 17, 2026
b114e1e
fixes to include validation logic
seventil Mar 24, 2026
1d9d2e5
Replaced defocus with a color flash
seventil Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/EasyApp/Gui/Elements/TextField.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ T.TextField {
id: control

property bool warned: false
property bool enterFlash: false

implicitWidth: implicitBackgroundWidth + leftInset + rightInset
|| Math.max(contentWidth, placeholder.implicitWidth) + leftPadding + rightPadding
Expand All @@ -31,7 +32,9 @@ T.TextField {
font.pixelSize: EaStyle.Sizes.fontPixelSize
//font.bold: control.activeFocus ? true : false

color: warned ?
color: enterFlash ?
EaStyle.Colors.themeForeground :
warned ?
EaStyle.Colors.red :
!enabled ?
EaStyle.Colors.themeForegroundDisabled :
Expand Down Expand Up @@ -80,6 +83,18 @@ T.TextField {
Behavior on border.color { EaAnimations.ThemeChange {} }
}

onAccepted: {
control.enterFlash = true
enterFlashTimer.start()
}

// Visual feedback for the user that editing finish was accepted
Timer {
id: enterFlashTimer
interval: 180
onTriggered: control.enterFlash = false
}

//Mouse area to react on click events
MouseArea {
id: mouseArea
Expand Down
17 changes: 16 additions & 1 deletion src/EasyApp/Gui/Elements/TextInput.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ T.TextField {
property bool warned: false
property bool selected: false
property bool minored: false
property bool enterFlash: false

implicitWidth: implicitBackgroundWidth + leftInset + rightInset ||
Math.max(contentWidth, placeholder.implicitWidth) + leftPadding + rightPadding
Expand All @@ -27,7 +28,9 @@ T.TextField {
font.pixelSize: EaStyle.Sizes.fontPixelSize
font.bold: control.activeFocus ? true : false

color: warned ?
color: enterFlash ?
EaStyle.Colors.themeForeground :
warned ?
EaStyle.Colors.red :
!enabled || readOnly || minored ?
EaStyle.Colors.themeForegroundMinor :
Expand Down Expand Up @@ -66,6 +69,18 @@ T.TextField {
color: 'transparent'
}

onAccepted: {
control.enterFlash = true
enterFlashTimer.start()
}

// Visual feedback for the user that editing finish was accepted
Timer {
id: enterFlashTimer
interval: 180
onTriggered: control.enterFlash = false
}

//Mouse area to react on click events
MouseArea {
id: mouseArea
Expand Down