Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9830e3952
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "--socket", | ||
| "$${SOCKET_DIR}/mysql.sock", |
There was a problem hiding this comment.
These new args reuse the same mysql.sock path as //examples/mysql:mysql_listening_on_socket, but SOCKET_DIR is created once per svcinit run and then substituted into every service spec (cmd/svcinit/main.go). That means a service_test or itest_service_group that starts both public MySQL examples will now launch two mysqld processes against the same Unix socket path, so one of them fails to start even though their TCP ports are different.
Useful? React with 👍 / 👎.
1 participant
No description provided.