Skip to content

WIP rework skill deeply#6533

Open
dubzzz wants to merge 16 commits intomainfrom
create-sub-reference-docs-skill
Open

WIP rework skill deeply#6533
dubzzz wants to merge 16 commits intomainfrom
create-sub-reference-docs-skill

Conversation

@dubzzz
Copy link
Owner

@dubzzz dubzzz commented Feb 3, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2026

⚠️ No Changeset found

Latest commit: 3f819b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 3, 2026

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6533

fast-check

npm i https://pkg.pr.new/fast-check@6533

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6533

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6533

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6533

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6533

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6533

commit: 3f819b9

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

👋 A preview of the new documentation is available at: http://698263bc35bc3c93e91b1856--dubzzz-fast-check.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

👋 A preview of the new documentation is available at: http://698277b93756ed858197cdc2--dubzzz-fast-check.netlify.app

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.85%. Comparing base (c1cffa8) to head (3f819b9).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6533   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         207      207           
  Lines        5581     5581           
  Branches     1468     1468           
=======================================
  Hits         5294     5294           
  Misses        274      274           
  Partials       13       13           
Flag Coverage Δ
tests 94.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

👋 A preview of the new documentation is available at: http://698453cbaa2e8307c23f83fb--dubzzz-fast-check.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

👋 A preview of the new documentation is available at: http://69848b8b1f8e7b17ac51c57b--dubzzz-fast-check.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

👋 A preview of the new documentation is available at: http://6984f32937c2d0ecc21c304b--dubzzz-fast-check.netlify.app

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

👋 A preview of the new documentation is available at: http://6984f48ce54626eb36f5d799--dubzzz-fast-check.netlify.app

dubzzz and others added 2 commits February 5, 2026 22:20
  Applied by GitHub Action workflow: PR Format
  Run ID: 21728949125
  Target PR: 6533
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

👋 A preview of the new documentation is available at: http://69850a4637c2d03d9a1c30a7--dubzzz-fast-check.netlify.app

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated!

Comment on lines +56 to +59
// ❌ Screenshot tests on ModalHeader won't make sense alone in many cases. Except if the component is supposed to be publically used. Same for all other internally used components.
// ✅ BUT testing their logic in an unitary fashion makes sense.

// ✅ Screenshot tests on Modal makes sense to avoid visual regressions.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ❌ Screenshot tests on ModalHeader won't make sense alone in many cases. Except if the component is supposed to be publically used. Same for all other internally used components.
// ✅ BUT testing their logic in an unitary fashion makes sense.
// ✅ Screenshot tests on Modal makes sense to avoid visual regressions.
// ✅ Screenshot tests on Modal makes sense to avoid visual regressions.

…6549)

Two new testing recipe references for the `javascript-testing-expert`
skill, covering UI component and workflow testing patterns.

### `test-design-system-components.md`
- Black-box/integration testing of public DS components
- In-browser screenshot tests for visual regression, DOM snapshots as
fallback
- a11y-first querying (`getByRole`, `getByLabelText`, `getByText` over
`getByTestId`)
- ARIA attribute verification and keyboard navigation checks
- Browser interactivity tests with testing-library fallback

### `test-complex-ui-workflows.md`
- Extract logic into pure functions, test with property-based testing
- Screenshot tests at macro-component level for key states
- Browser-based workflow validation (multi-step forms, dashboards)
- Model-based testing section with fast-check `ICommand` pattern for
stateful UIs with many interaction paths

```ts
// Model-based testing example for complex UI
class AddTodoCommand implements fc.ICommand<TodoModel, TodoApp> {
  constructor(readonly text: string) {}
  check() { return true; }
  run(model: TodoModel, real: TodoApp) {
    model.items.push(this.text);
    real.addItem(this.text);
    expect(real.getItems()).toEqual(model.items);
  }
  toString() { return `AddTodo(${this.text})`; }
}
```

### `SKILL.md`
- Added both references to the Testing recipes table

Both docs cross-reference `test-async-code.md`, `test-glue-code.md`, and
`property-based-testing.md` where relevant.

<!-- START COPILOT CODING AGENT SUFFIX -->



<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> Pull request: https://github.com/dubzzz/fast-check/pull/6533/files
> 
> based on this skill https://skills.sh/anthropics/skills/skill-creator
and by mimicking how we implemented other references, come up with
test-design-system-components explaining how how could test them.
recommend in-browser screenshot tests and checks of the interactivity,
and to fallback to testing-library when browser testing is not a thing.
recommend a11y checks to be ran, to follow the guidelines getByRole and
similar that are often the go-to recommandations for testing-library.
overall recommend testing design system components (the public ones) in
an integration/black box fashion
> 
> also come up with a doc for test-complex-ui-assemblages (replace
assemblages by something better). in this one mostly recommend
screenshot tests for non visual reg of the macro component. recommend
extracting pieces of logics as much as possible to make them easier to
test. for remaining logic suggest browser (or testing-library if no
browser) to check interactivity. recommend to have a look into model
based testing via fast-check, take our doc and examples to document it
slightly
> 
> for each of them maybe put a note regarding referring to other pages
if async code or complex sync code needs to be tested.


</details>



<!-- START COPILOT CODING AGENT TIPS -->
---

💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dubzzz <5300235+dubzzz@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

👋 A preview of the new documentation is available at: http://698512d43c328a5a2c2edf34--dubzzz-fast-check.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants