This repository was archived by the owner on Mar 25, 2024. It is now read-only.
Open
Conversation
I was unconvinced that `serde_yaml`'s deserializer was handling untagged enums correctly, but it appears that it is.
|
For reference, there's a known failure that affects untagged enums: #165 The reproduction example (original Rust Playground): use std::collections::BTreeMap;
use serde_yaml;
use serde::Deserialize;
fn main() {
let input = r#"
items:
bar: 42
baz: 123
200: 321
"#;
// Deserializing into `Items` will work, but not `Wrapper` as an untagged enum:
let wrapped: Wrapper = serde_yaml::from_str(input).expect("Couldn't deserialize");
println!("{:#?}", wrapped);
}
#[derive(Debug, Deserialize, PartialEq)]
#[serde(untagged)]
enum Wrapper {
Item(Items),
}
#[derive(Debug, Deserialize, PartialEq)]
struct Items {
items: BTreeMap<String, usize>,
}Fails with: EDIT: The above playground reproduction uses an It's due to number key |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unconvinced that
serde_yaml's deserializer was handling untagged enums correctly, but it appears that it is.