Span::file and Span::local_file suggest to use Rust 1.88 when using stable#536
Open
peter-lyons-kehl wants to merge 1 commit intodtolnay:masterfrom
Open
Span::file and Span::local_file suggest to use Rust 1.88 when using stable#536peter-lyons-kehl wants to merge 1 commit intodtolnay:masterfrom
peter-lyons-kehl wants to merge 1 commit intodtolnay:masterfrom
Conversation
Author
|
Tangentially related to #522. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you David for proc-macro2, serde and all the goodness.
You, and proc macro experts know that
Span::localandSpan::local_filestabilized in Rust only in 1.88.0, but proc-macro2 has those functions even with its current MSRV being lower.May we save people's time and give them a hint that they may want 1.88.0+ for this, please.
Good to have met you at RustConf in Portland, OR a few years ago, and then again (in Albuquerque from memory). Take care & bless you.