Skip to content

Show imported instances in dstack offer #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Mar 19, 2026
Merged

Show imported instances in dstack offer #3673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/dstack/_internal/server/services/instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,14 @@ async def get_pool_instances(
res = await session.execute(
select(InstanceModel)
.where(
InstanceModel.project_id == project.id,
or_(
InstanceModel.project_id == project.id,
exists().where(
ImportModel.project_id == project.id,
ImportModel.export_id == ExportedFleetModel.export_id,
ExportedFleetModel.fleet_id == InstanceModel.fleet_id,
),
),
InstanceModel.deleted == False,
)
.options(joinedload(InstanceModel.fleet))
Expand Down
13 changes: 12 additions & 1 deletion src/tests/_internal/server/routers/test_runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,11 +1388,22 @@ async def test_returns_run_plan_instance_volumes(

@pytest.mark.asyncio
@pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
@pytest.mark.parametrize(
"configuration",
[
pytest.param({"type": "dev-environment", "ide": "vscode"}, id="regular-configuration"),
pytest.param(
{"type": "task", "commands": [":"], "image": "scratch"},
id="special-configuration-used-by-dstack-offer-cli-command",
),
],
)
async def test_returns_run_plan_with_offer_from_imported_fleet(
self,
test_db,
session: AsyncSession,
client: AsyncClient,
configuration: dict,
) -> None:
importer_user = await create_user(session, global_role=GlobalRole.USER)
exporter_project = await create_project(session, name="exporter-project")
Expand Down Expand Up @@ -1424,7 +1435,7 @@ async def test_returns_run_plan_with_offer_from_imported_fleet(
exported_fleets=[fleet],
)

run_spec = {"configuration": {"type": "dev-environment", "ide": "vscode"}}
run_spec = {"configuration": configuration}
body = {"run_spec": run_spec}
response = await client.post(
"/api/project/importer-project/runs/get_plan",
Expand Down
Loading