Write payee for transfers in CSV export#146
Open
dtruebin wants to merge 1 commit intodsolonenko:masterfrom
Open
Write payee for transfers in CSV export#146dtruebin wants to merge 1 commit intodsolonenko:masterfrom
dtruebin wants to merge 1 commit intodsolonenko:masterfrom
Conversation
As far as tests go, I decided to only update the expected result(-s) without updating any of the actuals. In particular: - should_export_regular_transfer did not have a payee in its test transaction, so it stayed the same - should_export_split_transfer had a payee, meaning the export result should have it as well from now on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143
As far as tests go, I decided to only update the expected result(-s) without updating any of the actuals. In particular:
should_export_regular_transferdid not have a payee in its test transaction,so it stayed the same
should_export_split_transferhad a payee, meaning the export result shouldhave it as well from now on