Update SmsReceive: Deal with fixed number addition random number context #124
Open
hongnod wants to merge 1 commit intodsolonenko:masterfrom
Open
Update SmsReceive: Deal with fixed number addition random number context #124hongnod wants to merge 1 commit intodsolonenko:masterfrom
hongnod wants to merge 1 commit intodsolonenko:masterfrom
Conversation
Contributor
|
it can break existing functionality: consider you have 2 sms templates for 900 tel number and for 9001 - then the 9001 one can never be selected and 900 will be always triggered instead. |
Author
|
Yes, that case has such problem. but in reality, we don't have such kind of number.if actually has, define 9001 template as another 900 is enough. |
Author
|
#127 post a new request, maybe fix this case. |
Galletas78
approved these changes
Jul 4, 2024
Galletas78
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some SMS number will append random number on a fixed number, so save the fixed part ,if fixed part matches, process the transition.