[WIP] Add tutorials describing basic features of the product#107
Open
[WIP] Add tutorials describing basic features of the product#107
Conversation
Closed
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
f0c3cb4 to
602afa2
Compare
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
2961357 to
bd05a0a
Compare
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
04d42a1 to
4720f73
Compare
OlegLazaryev
suggested changes
Sep 21, 2018
Contributor
OlegLazaryev
left a comment
OlegLazaryev
left a comment
There was a problem hiding this comment.
Reviewed.
Let's discuss.
|
|
||
| }); | ||
|
|
||
| subscribeHighlightingElement(step1); |
Contributor
There was a problem hiding this comment.
This line is duplicated several times. What in this case makes it hardly maintainable. I have some ideas how to generalize it. Let's discuss in-person.
| } | ||
| }); | ||
|
|
||
| var step1 = tour.addStep('services-tab', { |
Contributor
There was a problem hiding this comment.
I have an idea of how to generalize the creation of steps. I think we can introduce a kind of a factory method to do that. Let's discuss in-person.
OlegLazaryev
suggested changes
Sep 24, 2018
Contributor
OlegLazaryev
left a comment
OlegLazaryev
left a comment
There was a problem hiding this comment.
@volodymyrtymtsiv reviewed.
Let's discuss.
| var selector = getSelector(step); | ||
|
|
||
| step.on('show', function () { | ||
| angular.element(selector).addClass('highlighted-element'); |
Contributor
There was a problem hiding this comment.
Let's use jQuery selector instead of Angular.
| angular.element(selector).addClass('highlighted-element'); | ||
| }); | ||
| step.on('before-hide', function () { | ||
| angular.element(selector).removeClass('highlighted-element') |
Contributor
There was a problem hiding this comment.
Let's use jQuery selector instead of Angular.
Contributor
|
A general notice which is looking like a bug:
|
OlegLazaryev
suggested changes
Sep 25, 2018
Contributor
OlegLazaryev
left a comment
OlegLazaryev
left a comment
There was a problem hiding this comment.
@volodymyrtymtsiv
Left you some more comments.
I think it is going to be the last round of review.
We will improve the remaining technical debt in the next related PRs.
Let me now when finished.
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
45f9c4e to
0addeef
Compare
OlegLazaryev
suggested changes
Sep 25, 2018
vtymtsiv
force-pushed
the
feature/DF-shepherd
branch
from
efb4071 to
84ef713
Compare
OlegLazaryev
approved these changes
Sep 25, 2018
added 3 commits
September 26, 2018 13:31
Refactor
…-scripting Feature/df tutorial scripting
Contributor
|
@wjgilmore please review. |
Contributor
|
Thank you will review this week. |
wjgilmore
reviewed
May 26, 2020
Contributor
wjgilmore
left a comment
wjgilmore
left a comment
There was a problem hiding this comment.
@volodymyrpoli do not merge this change. We now do this in Intercom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.