fix(job): support config sync peer task batch size#4654
Open
CooooolFrog wants to merge 2 commits intodragonflyoss:mainfrom
Open
fix(job): support config sync peer task batch size#4654CooooolFrog wants to merge 2 commits intodragonflyoss:mainfrom
CooooolFrog wants to merge 2 commits intodragonflyoss:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4654 +/- ##
==========================================
- Coverage 28.66% 28.07% -0.59%
==========================================
Files 231 232 +1
Lines 23052 23141 +89
==========================================
- Hits 6607 6496 -111
- Misses 15983 16204 +221
+ Partials 462 441 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
db9908d to
1eeaaed
Compare
1eeaaed to
12b4926
Compare
8 tasks
Signed-off-by: CooooolFrog <zuliangwanghust@gmail.com>
Signed-off-by: CooooolFrog <zuliangwanghust@gmail.com>
9eeb1b6 to
bcf97b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the Redis big key issue caused by SyncPeerJob when there are too many peers.
Related Issue
#4379
Motivation and Context
Dragonfly uses this library (https://github.com/RichardKnop/machinery) as a distributed task processor. This framework uses Redis as a task queue to store job requests and execution results (e.g. key JobResultId, value PeerHostInfos). The reason for big key problem in Redis is that the task result stores information for all peers.
I saw the group task scheduling in the machinery library, so I plan to split a job into multiple sub-jobs for execution. This would reduce the number of PeerHostInfo entries stored in a single sub-job, thus solving the big key problem.
Screenshots (if appropriate)
Types of changes
Checklist