fix(controller): ignore immutable field modifications for statefulset#519
Open
fix(controller): ignore immutable field modifications for statefulset#519
Conversation
… update Signed-off-by: Abhradeep Chakraborty <abhradeep@dragonflydb.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statefulset has some fields that are immutable e.g. volumeClaims. Any attempt to update these fields would fail causing the controller to be stuck in update state. Ignore these fields when update to the desired state. The controller will throw warnings if user tries to update immutable fields.
Note, this PR doesn't create a new statefulset to update the immutable fields. I think it would best to leave it for users to create a new Dragonfly resource with updated pvcs etc. i.e. making it behave identically with statefulset. Allowing updating these fields would need sts deletion, handling orphan pods etc. Manual handling of such cases makes more sense to me than by the dragonfly operator.