Skip incremental build timing assertions for NativeAOT#10937
Merged
jonathanpeppers merged 3 commits intomainfrom Mar 13, 2026
Merged
Skip incremental build timing assertions for NativeAOT#10937jonathanpeppers merged 3 commits intomainfrom
jonathanpeppers merged 3 commits intomainfrom
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jonathanpeppers
March 13, 2026 17:26
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Xamarin.Android build/test coverage to stop asserting incremental-build timing improvements for the NativeAOT runtime, since NativeAOT incremental builds aren’t guaranteed to be faster than clean builds.
Changes:
- Skip
BasicApplicationRepetitiveBuildforAndroidRuntime.NativeAOTviaAssert.Ignore. - Skip
AppProjectTargetsDoNotBreakforAndroidRuntime.NativeAOTviaAssert.Ignore. - Skip
RepetiviteBuildUpdateSingleResourceforAndroidRuntime.NativeAOTviaAssert.Ignore.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs |
Adds NativeAOT Assert.Ignore to two timing-sensitive incremental build tests. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidUpdateResourcesTest.cs |
Adds NativeAOT Assert.Ignore to an incremental resource update test with a timing assertion. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidUpdateResourcesTest.cs
Outdated
Show resolved
Hide resolved
Member
|
@copilot can you address the review comments: #10937 (review) |
… tests Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Contributor
Author
Addressed in c30674b. Instead of skipping entire tests with |
Copilot
AI
changed the title
Skip incremental build timing tests for NativeAOT
Skip incremental build timing assertions for NativeAOT
Mar 13, 2026
jonathanpeppers
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
RepetiviteBuildUpdateSingleResource(NativeAOT)test was failing because NativeAOT incremental builds aren't necessarily faster than clean builds. Incremental build timing is not a feature we care about for NativeAOT.Changes
Guarded only the timing comparison assertions with
if (runtime != AndroidRuntime.NativeAOT)in three tests, so the tests continue to run for NativeAOT and still validate incremental target-skipping behavior:RepetiviteBuildUpdateSingleResource(AndroidUpdateResourcesTest.cs) — the reported failing test; guarded the 1st-vs-2nd build time assertionBasicApplicationRepetitiveBuild(IncrementalBuildTest.cs) — guarded the 1st-vs-2nd build time assertionAppProjectTargetsDoNotBreak(IncrementalBuildTest.cs) — guarded the 3rd-vs-1st and 3rd-vs-2nd build time assertionsBasicApplicationRepetitiveReleaseBuildalready skips non-MonoVM runtimes, so no change was needed there.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.