build: fix oci-layout named context serialization#3811
Open
crazy-max wants to merge 2 commits intodocker:masterfrom
Open
build: fix oci-layout named context serialization#3811crazy-max wants to merge 2 commits intodocker:masterfrom
crazy-max wants to merge 2 commits intodocker:masterfrom
Conversation
crazy-max
commented
Apr 22, 2026
Comment on lines
+166
to
+169
| // FIXME: Use a relative temp dir here instead of t.TempDir(). On Windows, | ||
| // t.TempDir() returns an absolute path with a drive-letter colon, | ||
| // and this test feeds the path through an oci-layout:// ref where | ||
| // that colon can be misread as the tag separator. |
Member
Author
There was a problem hiding this comment.
This one looks like a bug in util/ocilayout on Windows. I will open a follow-up PR to fix this.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-oci-layout
branch
from
3b0d56f to
02ab807
Compare
4 tasks
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-oci-layout
branch
from
02ab807 to
dcf533e
Compare
crazy-max
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3793
needs or closes #3812
The build input path now parses the original OCI layout reference once, resolves the digest when needed, rewrites only the path to the temporary store ID, and serializes the result back through the shared
ocilayout.RefAPI. This keeps the named context flow from rebuilding the reference by hand and accidentally producing an empty tag segment.The regression in #3793 came from the named context code path turning a digest-only OCI layout reference into an invalid
oci-layout://<store>:@sha256:...form.