deprecated: Migrate changes made from srfit deprecation and change function names in pdf module#2
Merged
sbillinge merged 30 commits intodiffpy:mainfrom Mar 21, 2026
Merged
Conversation
cadenmyers13
commented
Mar 19, 2026
| ##### start data | ||
| #O0 rg_int sig_rg_int low_int sig_low_int rmax rhofit | ||
| #S 1 - PDF from PDFgetN | ||
| #P0 -68.04163 47.30471 0.14884 0.13136 1.50 0.1091 |
Contributor
Author
There was a problem hiding this comment.
Replaced this metadata from 2008 with metadata of our new format.
cadenmyers13
commented
Mar 19, 2026
| # | ||
| ############################################################################## | ||
| """Tests for pdf package.""" | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I broke out tests into their respective files. More work needs to be done on tests here. We just need more tests tbh
Contributor
Author
|
@sbillinge ready for review. This is going to fail tests because its using srfit functions that arent released yet, but it passes locally. I will have to think about how exactly we should release this alongside srfit. I think they will have to be released simultaneously |
Contributor
|
@cadenmyers13 just let me know how you want to handle the releases. We can do them at the same time, we just have to make sure they both work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecations on
diffpy.srfit.fitbaseare complete! No deprecation warnings are needed here because this hasnt been released. We will now redirect people usingdiffpy.srfit.pdfto usediffpy.cmipdf.