Skip to content

feat: put the signature cache behind a feature flag (enabled by default) #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hpeebles wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: put the signature cache behind a feature flag (enabled by default) #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d68bd1
Put the signature cache behind a feature flag (enabled by default)
hpeebles Mar 3, 2026
a1dfbe2
Merge branch 'main' into sig_cache
hpeebles Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions packages/ic-certificate-verification/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@ homepage.workspace = true

[dependencies]
candid.workspace = true
nom.workspace = true
thiserror.workspace = true
leb128.workspace = true
cached.workspace = true
cached = { workspace = true, optional = true }
sha2.workspace = true
lazy_static.workspace = true
parking_lot.workspace = true
lazy_static = { workspace = true, optional = true }
parking_lot = { workspace = true, optional = true }

ic-certification = { workspace = true }
ic-cbor.workspace = true
Expand All @@ -41,3 +40,7 @@ rand.workspace = true
rand_chacha.workspace = true

ic-types.workspace = true

[features]
default = ["signature_cache"]
signature_cache = ["cached", "lazy_static", "parking_lot"]
14 changes: 13 additions & 1 deletion packages/ic-certificate-verification/src/signature_verification/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use self::signature_cache::{SignatureCache, SignatureCacheEntry};
use crate::CertificateVerificationError;
use ic_verify_bls_signature::verify_bls_signature;

#[cfg(feature = "cached")]
mod signature_cache;

#[cfg(test)]
Expand All @@ -10,11 +10,14 @@ mod reproducible_rng;
#[cfg(test)]
mod tests;

#[cfg(feature = "cached")]
pub fn verify_signature(
pk: &[u8],
sig: &[u8],
msg: &[u8],
) -> Result<(), CertificateVerificationError> {
use self::signature_cache::{SignatureCache, SignatureCacheEntry};

let entry = SignatureCacheEntry::new(pk, sig, msg);

if SignatureCache::global().contains(&entry) {
Expand All @@ -28,3 +31,12 @@ pub fn verify_signature(
SignatureCache::global().insert(&entry);
Ok(())
}

#[cfg(not(feature = "cached"))]
pub fn verify_signature(
pk: &[u8],
sig: &[u8],
msg: &[u8],
) -> Result<(), CertificateVerificationError> {
verify_bls_signature(sig, msg, pk).map_err(|_| CertificateVerificationError::SignatureVerificationFailed)
}
Loading