JDBetteridge/Composite actions by JDBetteridge · Pull Request #2868 · devitocodes/devito

JDBetteridge · 2026-03-06T23:50:18Z

Create composite actions for executing Docker things in workflows.

Makes stuff more consistent

The following workflows were renamed to be more descriptive/consistent:

pytest-mpi (gcc) → pytest-mpi (pytest-mpi-docker-gcc)
pytest-mpi (icx) → pytest-mpi (pytest-mpi-docker-icx)

Which needs updating in the repo settings

codecov · 2026-03-07T00:53:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.48%. Comparing base (e147aaa) to head (0a51941).

❗ There is a different number of reports uploaded between BASE (e147aaa) and HEAD (0a51941). Click for more details.

HEAD has 17 uploads less than BASE

Flag BASE (e147aaa) HEAD (0a51941)

18 1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2868       +/-   ##
===========================================
- Coverage   79.05%   61.48%   -17.58%     
===========================================
  Files         248      193       -55     
  Lines       51276    31363    -19913     
  Branches     4431     3805      -626     
===========================================
- Hits        40534    19282    -21252     
- Misses       9932    11136     +1204     
- Partials      810      945      +135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

.github/actions/docker-build/action.yaml

JDBetteridge · 2026-03-16T15:01:09Z

.github/actions/docker-clean/action.yaml

+  uid:
+    description: "Unique identifier output from docker-build action"
+    required: true
+  tag:


I pass both uid and tag everywhere, should these be combined into a single output from build and single input for clean and run? A unique_tag?

.github/workflows/tutorials.yaml

JDBetteridge · 2026-03-16T15:03:21Z

.github/actions/docker-run/action.yaml

+    required: true
+  command:
+    description: "Command to execute inside of the docker container"
+    required: true


A limitation of this approach is that only one command can be run in a container at once, making the workflows a little verbose in some places.

.github/actions/docker-run/action.yaml

.github/workflows/tutorials.yaml

.github/actions/docker-run/action.yaml

EdCaunt · 2026-03-16T17:12:45Z

.github/workflows/pytest-core-nompi.yaml

+      OMP_NUM_THREADS: 2
+
+    strategy:
+      # Prevent all build to stop if a single one fails


Might as well correct grammar on this comment

All your base are belong to us

Showing your advanced age there...

mloubout

Looks great, thanks a lot!!

Left a bunch of generic comments that aren't strong change requests. Do those action files really need to be in three different directories? Why not just .github/actions/docker for all

.github/actions/docker-build/action.yaml

.github/actions/docker-run/action.yaml

.github/workflows/pytest-core-mpi.yaml

.github/workflows/pytest-core-nompi.yaml

mloubout · 2026-03-20T13:13:24Z

.github/workflows/tutorials.yaml

+    strategy:
+      # Prevent cancellation if a single workflow fails
+      fail-fast: false
+      matrix:


It's a single entry, can drop the matrix and just put the values where needed, e.g

tutorials-docker: name: tutos-docker-gcc-py310 runs-on: $ubuntu-latest

and so on

I agree, but I was also going to raise the possibility of testing with some newer compilers in the next dev meeting, so I left it like this to be extensible (and consistent)

.github/workflows/tutorials.yaml

JDBetteridge · 2026-03-20T13:40:48Z

.github/workflows/pytest-core-mpi.yaml

+    - id: build
+      name: Build docker image
+      uses: ./.github/actions/docker-build
+      with:
+        file: docker/Dockerfile.devito
+        tag: ${{ matrix.name }}
+        base: devitocodes/bases:cpu-${{ matrix.arch }}


@mloubout here we don't use base

JDBetteridge · 2026-03-20T15:20:54Z

Do those action files really need to be in three different directories

Sadly yes, you cannot use them otherwise 😞

JDBetteridge force-pushed the JDBetteridge/unique_ci_docker_tag branch 4 times, most recently from 1ac1672 to 74a1f49 Compare March 16, 2026 14:57

JDBetteridge commented Mar 16, 2026

View reviewed changes

JDBetteridge changed the title ~~JDBetteridge/unique ci docker tag~~ JDBetteridge/Composite actions Mar 16, 2026

JDBetteridge marked this pull request as ready for review March 16, 2026 15:07

JDBetteridge force-pushed the JDBetteridge/unique_ci_docker_tag branch 4 times, most recently from fd7bcda to 2b457f6 Compare March 16, 2026 16:20

EdCaunt reviewed Mar 16, 2026

View reviewed changes

JDBetteridge force-pushed the JDBetteridge/unique_ci_docker_tag branch from ae9f243 to 5835ad4 Compare March 16, 2026 19:59

mloubout reviewed Mar 20, 2026

View reviewed changes

JDBetteridge commented Mar 20, 2026

View reviewed changes

JDBetteridge and others added 9 commits March 20, 2026 15:19

ci: Add composite actions and test in core-mpi

7e414c9

ci: Test new actions in nompi workflow

0d6bda8

ci: Split core-nompi into basic and docker

e079057

ci: Use composite actions for GPU tests

b291607

ci: Use composite actions for tutorials

8390d9c

misc: Make base optional

b49219f

ci: Add optional name parameter to the run composite action

1dc1857

misc: Tweaks

f8abdae

ci: Build needs to take additional args for pyarmored builds

e722b59

JDBetteridge force-pushed the JDBetteridge/unique_ci_docker_tag branch from 9d3406a to 1f75496 Compare March 20, 2026 15:19

JDBetteridge added 2 commits March 20, 2026 15:24

misc: Address review comments

b2e9990

docs: Document the composite actions

0a51941

JDBetteridge force-pushed the JDBetteridge/unique_ci_docker_tag branch from 1f75496 to 0a51941 Compare March 20, 2026 15:24

mloubout added testing CI continuous integration installation labels Mar 20, 2026

mloubout approved these changes Mar 20, 2026

View reviewed changes

Conversation

JDBetteridge commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mloubout left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JDBetteridge commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JDBetteridge commented Mar 6, 2026 •

edited

Loading

codecov bot commented Mar 7, 2026 •

edited

Loading