Feature/admin forth/1281/let's add hard limit to transl#12
Open
Feature/admin forth/1281/let's add hard limit to transl#12
Conversation
…r translation requests
ivictbor
commented
Feb 25, 2026
index.ts
Outdated
| const stringsToTranslate = strings.map( s => s.en_string); | ||
| const generationTasks = [] | ||
| while (stringsToTranslate.length !== 0) { | ||
| let stringBanch = []; |
| continue; | ||
| } | ||
| } | ||
| if ( stringBanch.length === 0 ) { |
Contributor
Author
There was a problem hiding this comment.
@yaroslav8765 but if there is some one string which is larger itself then allowedTokensAmountForFields , there will be no warning for user right? So he will not understand why some string was not translated
Contributor
There was a problem hiding this comment.
I've improved notifications system
index.ts
Outdated
| let stringBanch = []; | ||
| let banchTokens = 0; | ||
| for (const string of stringsToTranslate) { | ||
| if( banchTokens + enStringsTokenLengthCache[string] <= allowedTokensAmountForFields ) { |
Contributor
Author
There was a problem hiding this comment.
if string is e.g. 4 KiB then indexing by such string kills CPU, do we have uuid to address? and not using en_string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.