Skip to content

fix: Fix path parsing for copy, rename#672

Merged
kylebarron merged 4 commits intomainfrom
kyle/fix-pypath-parse
Apr 22, 2026
Merged

fix: Fix path parsing for copy, rename#672
kylebarron merged 4 commits intomainfrom
kyle/fix-pypath-parse

Conversation

@kylebarron
Copy link
Copy Markdown
Member

@kylebarron kylebarron commented Apr 22, 2026

Change list

  • Use PyPath instead of String as parameter input for copy, list, and rename
  • Add tests
  • Bump pyo3 version from 0.28.2 to 0.28.3 to fix CI

Closes #671

The primary change to avoid auto-percent-encoding of paths was done in #524, but it looks like we missed path inputs for copy/rename.

@kylebarron kylebarron changed the title Kyle/fix pypath parse fix: Fix path parsing for copy, list, rename Apr 22, 2026
@ds-release-bot ds-release-bot Bot added the fix label Apr 22, 2026
@kylebarron kylebarron changed the title fix: Fix path parsing for copy, list, rename fix: Fix path parsing for copy, rename Apr 22, 2026
@kylebarron
Copy link
Copy Markdown
Member Author

Since the main breaking change was in #524 , I think this can be considered a bugfix and go in a patch release.

@kylebarron kylebarron merged commit cb88ed2 into main Apr 22, 2026
11 checks passed
@kylebarron kylebarron deleted the kyle/fix-pypath-parse branch April 22, 2026 18:01
kylebarron added a commit that referenced this pull request Apr 22, 2026
…lease branch (#673)

* fix: Fix path parsing for copy, list, rename

* Add tests

* bump pyo3 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

obs.copy (and obs.rename) fails on non-ASCII filenames (e.g. with accented characters)

1 participant