feat(buffered): deprecate ReadableFile.meta and AsyncReadableFile.meta#667
Merged
kylebarron merged 2 commits intodevelopmentseed:mainfrom Apr 15, 2026
Merged
Conversation
kylebarron
reviewed
Apr 15, 2026
kylebarron
reviewed
Apr 15, 2026
| !!! warning "Deprecated" | ||
|
|
||
| This attribute is deprecated and will be removed in a future | ||
| release. Call [`obstore.head`][obstore.head] directly if you |
Member
There was a problem hiding this comment.
But alas here it is nicer to be able to point to a specific method. I was considering refactoring the docs to expose the mixin itself #634
kylebarron
approved these changes
Apr 15, 2026
Member
|
I think this is fine to merge and prepare for a patch release. Thanks! |
kylebarron
reviewed
Apr 15, 2026
fvaleye
force-pushed
the
refactor/readable-file-deprecate-meta
branch
from
ccd2b3e to
234c322
Compare
Member
|
I published 0.9.3: https://github.com/developmentseed/obstore/releases/tag/py-v0.9.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agreed on in #664 (review comment).
Adds the deprecation warning now, so it can ship in a patch release: the actual removal + struct simplification stays on #664 for the next breaking release.
Follow-up
The actual removal of
.metaand the struct simplification to{reader, size, r#async}lives on #664