Limit public methods on obstore.auth.AzureCredentialProvider#442
Merged
kylebarron merged 2 commits intomainfrom May 12, 2025
Merged
Limit public methods on obstore.auth.AzureCredentialProvider#442kylebarron merged 2 commits intomainfrom
obstore.auth.AzureCredentialProvider#442kylebarron merged 2 commits intomainfrom
Conversation
kylebarron
changed the title
obstore.auth.AzureCredentialProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an oversight of mine in the initial PR to add the
AzureCredentialProviderin #343 (cc @daviewales)Change list
obstore.auth.AzureCredentialProviderandobstore.auth.AzureAsyncCredentialProviderthat were previously accidentally public.scopesandtenant_idparameters in the__init__of those two classes are now keyword-only parameters.