Check and forward any trailers on stream end.#90
Merged
devashishdxt merged 1 commit intodevashishdxt:mainfrom Apr 9, 2026
Merged
Conversation
When errors occur on a stream it is sent as a trailer, but the current client does not look for them. This makes an error sent from a server look like a successfully completed stream. This PR makes tonic-web-wasm-client behave the same as most grpc implementations in that the errors in the trailer is forwarded.
Contributor
Author
|
I took the liberty of creating a PR that fixes an issue I had when using this crate on a grpc stream at work - happy to address any feedback! |
devashishdxt
approved these changes
Apr 9, 2026
Owner
|
Thanks for the PR. I'll merge this and push a new version on crates.io |
Contributor
Author
Wonderful! Sorry for hounding you, but you might have missed the release to crates.io? Don't see it there yet! |
Owner
Released on crates.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When errors occur on a stream it is sent as a trailer, but the current client does not look for them. This makes an error sent from a server look like a successfully completed stream.
This PR makes tonic-web-wasm-client behave the same as most grpc implementations in that the errors in the trailer is forwarded.