Fix minizip include due to minizip.pc change in zlib 1.3.2#284
Open
mymedia2 wants to merge 1 commit intodesktop-app:masterfrom
Open
Fix minizip include due to minizip.pc change in zlib 1.3.2#284mymedia2 wants to merge 1 commit intodesktop-app:masterfrom
mymedia2 wants to merge 1 commit intodesktop-app:masterfrom
Conversation
zlib of version 1.3.2 removed /minizip suffix from the include path in their pkg-config metadata and suggested to move to #include <minizip/(un)?zip.h>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zlib of version 1.3.2 removed /minizip suffix from the include path in their pkg-config metadata and suggested to include headers with <minizip/zip.h> or <minizip/unzip.h> directives.
Justification see at:
madler/zlib@7e6f078
This change should not conflict with minizip-ng, popular zlib fork, because they install zip.h and unzip.h files to the /usr/include/minizip directory. At least, Fedora has the minizip-ng-compat-devel package.
https://packages.fedoraproject.org/pkgs/minizip-ng/minizip-ng-compat-devel/fedora-rawhide.html#files
And that is [telegramdesktop/tdesktop#16962] may be reverted.