Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the srv-rs crate for a v1.0.0 release by updating the crate’s published version and aligning user-facing documentation with the new release.
Changes:
- Bump crate version from
0.2.0to1.0.0inCargo.toml. - Update the README dependency snippet to reference
srv-rsv1.0.0. - Update the
authorsmetadata inCargo.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates the Cargo.toml usage snippet to reference v1.0.0. |
| Cargo.toml | Bumps package version to 1.0.0 and updates package metadata (authors). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Minor review feedback:
|
Done.
I decided against implementing this: there's not much (if any) benefit to the end user IMO
This is the most interesting one. I wanted to make this RFC-compliant, but literally implementing the algorithm as specified in the RFC would've required a somewhat large refactor of the codebase. Instead, I heavily leaned on Claude to research an alternative implementation of |
Aside from it being potentially overkill, potentially slower. I'll benchmark this, actually... |
It came back over 3 times slower. Coupled with the decreased readability of that implementation, I decided to revert back to the original and add a comment about it being an approximation. |
986410c to
07ac8f2
Compare
I think this library is in good enough shape to call a 1.0 release. Changes from v0.2.0, stolen from the GitHub release notes generator:
What's Changed
impl Into<String>over&impl ToStringby @lvkv in Refactor: Acceptimpl Into<String>over&impl ToString#32I haven't made the following changes, but am open to being convinced:
async-traitCC @max-heller