[CB] SQL Query generation: add settings for the Generated SQL window#4275
Open
sergeyteleshev wants to merge 4 commits intodbeaver/pro#8716-generated-sql-optionsfrom
Conversation
…l-query-generation-add-settings-for-the-generated-sql-window
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Wroud
approved these changes
Apr 9, 2026
Comment on lines
+43
to
+44
| const DEFAULT_USE_FULLY_QUALIFIED_NAMES = true; | ||
| const DEFAULT_COMPACT_SQL = false; |
Member
There was a problem hiding this comment.
why do you have this constants in multiple files?
devnaumov
approved these changes
Apr 10, 2026
| const query = await this.sqlGeneratorsResource.generateEntityQuery( | ||
| action.id, | ||
| node.id, | ||
| DEFAULT_USE_FULLY_QUALIFIED_NAMES, |
Member
There was a problem hiding this comment.
Declare this defaults constants in sqlGeneratorsResource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/8328