Conversation
|
I am a bit concerned that the "tidying of the code", for example removing spaces, could cause problems when we come to merge v6.3.6-dev, v6.4.0-dev, ...., lots of conflicts. Could these changes be moved to a PR on v6.3.6-dev, moving them earlyed in release history. I notices at the tests don't check that the results for the call which don't now return anything, I think that should check there are any results as intended. |
|
Thanks Stuart, this is still draft so I was going to work a bit more before asking for your review! I will revert any changes which change whitespace etc. I also need to check tests further. |
|
|
It should return a result, but we can check that the serverside object has been created correctly? I will look today |
|
It would be an improvement if assignments could return a limited outcome. |
|
What outcome did you have in mind? A success message?
…________________________________
From: Stuart Wheater ***@***.***>
Sent: Friday, March 13, 2026 11:40 AM
To: datashield/dsBaseClient ***@***.***>
Cc: Cadman, TJ (medgen) ***@***.***>; Author ***@***.***>
Subject: Re: [datashield/dsBaseClient] Perf batch 1 (PR #656)
[https://avatars.githubusercontent.com/u/4047704?s=20&v=4]StuartWheater left a comment (datashield/dsBaseClient#656)<#656 (comment)>
It would be an improvement if assignments could return a limited outcome.
—
Reply to this email directly, view it on GitHub<#656 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ4MXRMVV5PFXA2HYLGOOB34QPQTHAVCNFSM6AAAAACWQAPZ2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANJUGE4DSOBSHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
________________________________
De inhoud van dit bericht is vertrouwelijk en alleen bestemd voor de geadresseerde(n). Anderen dan de geadresseerde(n) mogen geen gebruik maken van dit bericht, het niet openbaar maken of op enige wijze verspreiden of vermenigvuldigen. Het UMCG kan niet aansprakelijk gesteld worden voor een incomplete aankomst of vertraging van dit verzonden bericht.
The contents of this message are confidential and only intended for the eyes of the addressee(s). Others than the addressee(s) are not allowed to use this message, to make it public or to distribute or multiply this message in any way. The UMCG cannot be held responsible for incomplete reception or delay of this transferred message.
|
|
My thought process for this was that with R, you don't receive a message confirming that the process has worked. You just receive an error message. So I was thinking we do the same with DataSHIELD - let the server handle/return any errors, and if nothing is returned then it indicates the operation was successful |
2 participants
No description provided.