Get-DecryptedObject: Refactor related commands#10130
Draft
andreasjordan wants to merge 6 commits intodevelopmentfrom
Draft
Get-DecryptedObject: Refactor related commands#10130andreasjordan wants to merge 6 commits intodevelopmentfrom
andreasjordan wants to merge 6 commits intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get-DecryptedObjectneeds two things:That's why
Get-DecryptedObjectneeds$Credentialwhich it used all the time, but the parametr was missing.So every command that calls
Get-DecryptedObjectneeds$Credentialas well. This is:So every command that calls one of those commands needs
$Credentialas well. This is:TODO:
More problems:
Get-DecryptedObjectopen and close a DAC. But if they are called from other commands or from scripts using an already open DAC, then they must noch close this DAC.I hope I can solve that nightmare in the next days, but maybe it will take until next weekend.