chore: fix clippy warnings surfaced by Rust 1.95#83
Open
youichi-uda wants to merge 1 commit intodatafusion-contrib:mainfrom
Open
chore: fix clippy warnings surfaced by Rust 1.95#83youichi-uda wants to merge 1 commit intodatafusion-contrib:mainfrom
youichi-uda wants to merge 1 commit intodatafusion-contrib:mainfrom
Conversation
Rust 1.95 / clippy 1.95 promoted two lints to warnings which now fail CI under `-D warnings`: - `clippy::useless_conversion` in `src/row_index.rs`: drop the redundant `.into_iter()` in a `zip()` argument. - `clippy::explicit_counter_loop` in `src/encoding/integer/rle_v2/delta.rs`: rewrite two manual counter loops in the test module with `.enumerate()`. No behaviour change; CI on `main` is currently green because the last push predates the Rust 1.95 release, but any new PR hits these warnings.
progval
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rust 1.95 / clippy 1.95 promoted two lints to warnings that now break CI on any PR because the workflow runs clippy with
-D warnings:clippy::useless_conversioninsrc/row_index.rs:283— drop a redundant.into_iter()inside azip()argument (IntoIteratoris already accepted).clippy::explicit_counter_loopinsrc/encoding/integer/rle_v2/delta.rs:254and:283— rewrite two manual counter loops in the test module with.enumerate().No behaviour change.
mainis currently green only because the last push predates the Rust 1.95 release; any new PR (e.g. #82) now fails all three Clippy jobs on these pre-existing lines.Test plan
cargo clippy --workspace --all-targets -- -D warningscargo clippy --workspace --all-targets --all-features -- -D warningscargo clippy --workspace --all-targets --no-default-features -- -D warningsAll three pass locally on Rust 1.95.0.