fix: objectRemoveKey exclusions leaking across + inheritance boundaries#659
Merged
stephenamar-db merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
objectRemoveKey's excludedKeys mechanism suppressed re-added keys in
both directions of object inheritance via +.
Two fixes in Val.Obj:
1. gatherKeys: replaced global exclusion set with incremental processing
during root-first iteration. Each object's excludedKeys removes keys
from lower levels, but higher-level objects can re-introduce them.
Fixes: removeKey(obj, k) + {k: v}
2. addSuper: when the RHS has excludedKeys and the LHS provides those
keys as visible, inject synthetic members that delegate to the LHS
and clear the exclusion. Fixes: {k: v} + removeKey(obj, k)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objectRemoveKey's excludedKeys mechanism suppressed re-added keys in both directions of object inheritance via +.
Two fixes in Val.Obj:
gatherKeys: replaced global exclusion set with incremental processing during root-first iteration. Each object's excludedKeys removes keys from lower levels, but higher-level objects can re-introduce them. Fixes: removeKey(obj, k) + {k: v}
addSuper: when the RHS has excludedKeys and the LHS provides those keys as visible, inject synthetic members that delegate to the LHS and clear the exclusion. Fixes: {k: v} + removeKey(obj, k)