Use t.Context() instead of context.Background() in tests#4655
Open
Use t.Context() instead of context.Background() in tests#4655
Conversation
Go 1.24 added t.Context() which returns a context scoped to the test lifetime. Use it everywhere instead of context.Background(). Add a ruleguard lint rule to prevent context.Background() from being reintroduced in test files. Add Context() to the TestingT interface so test helpers that accept it can use t.Context() as well. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pietern
requested review from
a team,
alexott,
andrewnester,
anton-107,
denik,
jefferycheng1,
kanterov,
lennartkats-db,
nfx,
shreyas-goenka and
simonfaltum
as code owners
Collaborator
|
Commit: f8e6423
25 interesting tests: 8 FAIL, 7 KNOWN, 7 SKIP, 2 flaky, 1 BUG
Top 21 slowest tests (at least 2 minutes):
|
t.Context() is cancelled just before t.Cleanup() functions run, so cleanup functions that make API calls need a non-cancelled context. Use context.WithoutCancel() to preserve auth/config values while removing the cancellation signal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go 1.24 added
t.Context()/b.Context()which return a context scoped to the test lifetime. This replaces allcontext.Background()usage in tests and test helpers with the scoped alternative.Context()to theTestingTinterfacecontext.Background()in_test.gofilesTest plan
Tests pass.
🤖 Generated with Claude Code