List postgres databases during Lakebase plugin selection, add option to ignore fields in bundles#4634
Open
pkosiec wants to merge 6 commits intopkosiec/bump-go-sdkfrom
Open
List postgres databases during Lakebase plugin selection, add option to ignore fields in bundles#4634pkosiec wants to merge 6 commits intopkosiec/bump-go-sdkfrom
pkosiec wants to merge 6 commits intopkosiec/bump-go-sdkfrom
Conversation
Collaborator
|
Commit: 7bd03bc
29 interesting tests: 14 FAIL, 7 SKIP, 6 RECOVERED, 2 KNOWN
Top 10 slowest tests (at least 2 minutes):
|
pkosiec
force-pushed
the
pkosiec/postgres-db-lister
branch
from
b31a392 to
c8c3c0d
Compare
pkosiec
changed the title
Revert the description hint and Filtering(true/false) changes in promptFromListWithLabel and PromptForAppSelection, as these are addressed properly in PR #4603. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pkosiec
force-pushed
the
pkosiec/postgres-db-lister
branch
from
7bd03bc to
e8ec949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
databricks.ymlfile (for Lakebase, we need aLAKEBASE_ENDPOINTenv that shouldn't be listed in the DAB)See also databricks/appkit#132
Resolves https://databricks.atlassian.net/browse/LKB-10074
Testing
Test it together with #4634
make build)databricks apps initcommand with custom template (locally cloned one) - replace the path:DATABRICKS_APPKIT_TEMPLATE_PATH="/Users/pawel.kosiec/repositories/databricks-os/appkit/template" dbx apps initdatabricks.ymlresources.apps.app.resourcesand all unused variables (postgres_branch,postgres_database).databricks apps deployDemo
init-flow.mov